Simply changing the association will not change the application icon.
Certain associations also use their own icon handler which stops you from changing the icon explorer uses. I cant remember offhand if Photoshop is like this, but if the icon isnt changing then chances are its Photoshot keeping control of that icon.